[
http://issues.apache.org/jira/browse/VELOCITY-403?page=comments#action_12330812
]
Nathan Bubna commented on VELOCITY-403:
---------------------------------------
Regarding Java 1.4:
it need only be a compile time dependency. If a user is running 1.3, then
it will fail just as if the user didn't have LogKit or Log4j in the classpath.
I think that is totally legitimate. Active developers should have 1.4 or 1.5
on their system already. This should be no burden to anyone compiling velocity
themselves, and it may be a great benefit to many users who upgrade. i pretty
strenously object to leaving this out.
Regarding the change to LogSystem:
it's two simple methods. anyone competent enough to implement their own
LogSystem can very easily add these in a way that's BC for their app. most
importantly, the LogSystem interface is really a developer extension point, far
more than a standard user API. i would oppose changing user API w/o a
deprecation path, but developers should be far more on top of things. i really
don't think it's worth the LogInterface hack for those precious few, highly
capable developers' convenience. but, if this will block the commit, i'll look
into it more.
Regarding c-l before 2.0:
Not gonna happen. We've been over this multiple times. Please don't go
there right now. Save it for later. I'll deal with the problem of
Tools+Tomcat 5.5 after this patch goes thru.
> Enhance Velocity's LogSystem and internal use thereof
> -----------------------------------------------------
>
> Key: VELOCITY-403
> URL: http://issues.apache.org/jira/browse/VELOCITY-403
> Project: Velocity
> Type: Improvement
> Components: Source
> Reporter: Nathan Bubna
> Fix For: 1.5
> Attachments: logging.patch
>
> After several very, very long debates with Geir over commons-logging, i have
> become largely convinced that it is something we should do with hesitation
> (i.e. let's talk about it for 2.0, but not before). i've also begun to have
> some frustrations with commons-logging in both work projects and in
> VelocityTools.
> regardless of these issues, it is clear to me that Velocity's LogSystem and
> use of it is in great need of improvement. we need to lower the priority of
> many messages, eliminate some, and above all, upgrade the system itself to be
> more useful.
> some specific, unevaluated, off-the-cuff ideas are:
> -make logging a null-op if no logger is found, rather than panic and break
> -detect jdk 1.4+ logging
> -add a trace level
> -add is<Level>Enabled
> -make it possible to grab a LogSystem instance of sorts, so Velocity
> extensions can use it more sensibly (i'm tired of the hacks we must do in
> Tools)
> those are just a few ideas, and they might not all even be feasible. still,
> i'm hoping to take a whack at some of this and hoping that others can help me
> out. my volunteer time is still rather limited.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
