I was trying to wrap my brain around the current log code, following a
possible null pointer dereference in LogManager and found a twisted
little maze of code...
Nathan, as this is your baby, do you object to some of the following
changes:
- Nuke the public C'tor for Log(). Do we want anyone walk around and
create new Log instances? Add a LogManager.getLog() method which returns
a Log object.
- Make LogManager.createLogChute() private. This should _only_ be called
from LogManager.updateLog()
- Make HoldingLogChute() package private. Even better, make it a private
static inner class of LogManager. We never ever want users to use that
directly. It is a vehicle intended for pre-init logging.
- rename HoldingLogChute() to PreInitLogChute()
- rename LogChuteSystem() to LogSystemLogChute() :-)
Some bike shed painting here, I admit.
Best regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED] +49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
Linux, Java, perl, Solaris -- Consulting, Training, Development
4 - 8 - 15 - 16 - 23 - 42
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
