[ http://issues.apache.org/jira/browse/VELOCITY-78?page=all ]
Will Glass-Husain resolved VELOCITY-78:
---------------------------------------
Resolution: Fixed
Thanks for giving in, Nathan and making the patch.
I agree with Henning's comment in Velocity-193 that relying on finalize is not
perfect, but it should be a big improvement.
Note that I added a line to set appender to null, allowing shutdown to be
called multiple times with no effect.
> SimpleLog4JLogSystem closes appenders
> -------------------------------------
>
> Key: VELOCITY-78
> URL: http://issues.apache.org/jira/browse/VELOCITY-78
> Project: Velocity
> Type: Bug
> Components: Source
> Versions: 1.3-rc1
> Environment: Operating System: other
> Platform: All
> Reporter: Steven Hugg
> Priority: Minor
> Fix For: 1.5
> Attachments: simplelog4jlogsystem.patch
>
> The SimpleLog4JLogSystem class closes all appenders in its shutdown() method,
> even if the appenders were not created by Velocity. This can cause problems
> if
> the logging system is initialized in your servlet, and if Velocity instances
> are finalized while other instances are in use -- since Log4J Categories are
> static :P
> What should probably happen is a flag should be set so that appenders are
> only
> closed if they were created by the SimpleLog4JLogSystem class, and/or when
> all
> Velocity instances are GC'ed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
