[ http://issues.apache.org/jira/browse/VELOCITY-453?page=comments#action_12433333 ] Alexey Panchenko commented on VELOCITY-453: -------------------------------------------
The reason not to use the EqualsBuilder and HashcodeBuilder is the performance. > [PATCH] Fix IntrospectionCacheData caching > ------------------------------------------ > > Key: VELOCITY-453 > URL: http://issues.apache.org/jira/browse/VELOCITY-453 > Project: Velocity > Issue Type: Bug > Components: Source > Affects Versions: 1.5 > Reporter: Alexey Panchenko > Assigned To: Will Glass-Husain > Fix For: 1.5 > > Attachments: ASTMethod_IntrospectionCacheData_cache, > ASTMethod_IntrospectionCacheData_cache-v2-retry.patch, > ASTMethod_IntrospectionCacheData_cache-v2.patch, > IntrospectionCacheDataTest-no-copyright.java, > IntrospectionCacheDataTest-no-copyright.java, > IntrospectionCacheDataTest-v4.java, IntrospectionCacheDataTest.java > > > The old code used Class[].hashCode() in MethodCacheKey.hashCode() > implementation. > hashCode() is not overriden for arrays so it returns different value for each > array instance. > The attached is the correct implementation and a test case to prove the > caching actually works. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
