[ http://issues.apache.org/jira/browse/VELTOOLS-58?page=comments#action_12433999 ] Nathan Bubna commented on VELTOOLS-58: --------------------------------------
Hmm. Here's the latest JavascriptValidatorTag.java source as a reference: http://svn.apache.org/viewvc/struts/struts1/trunk/taglib/src/main/java/org/apache/struts/taglib/html/JavascriptValidatorTag.java?view=markup and the javadoc for the Resources class http://struts.apache.org/1.x/struts-core/apidocs/org/apache/struts/validator/Resources.html i can't see the difference in Resources docs, nor did it make a difference for you, but since JavascriptValidatorTag makes the change you suggest, we probably should too. in general though, it looks like we need a way for you to request a specific bundle to be used at the start of the getDynamicJavascript(...) method where the MessageResources are obtained. This probably means matching versions of all the public methods but with the addition of a bundle parameter. > ValidatorTool does not respect 'bundle' property for message elements when > generating client-side validation code. > ------------------------------------------------------------------------------------------------------------------ > > Key: VELTOOLS-58 > URL: http://issues.apache.org/jira/browse/VELTOOLS-58 > Project: VelocityTools > Issue Type: Bug > Components: VelocityStruts > Affects Versions: 1.2, 1.3 > Environment: JDK 1.4.2_09 / Tomcat 4.1.31 / Struts 1.2.7 / > Commons-Validator 1.1.4 > Reporter: Christopher Schultz > > I recently decided to split my application properties files into multiple > bundles instead of one huge bundle in an effort to maintain some order. This > required me to change my validation configuration to include the "bundle" > property on my message elements: > <field property="questionTypeId" > depends="required,integer"> > <arg position="0" bundle="Clinician" > key="prompt.responseOption.questionTypeId"/> > </field> > The ValidatorTool.getDynamicJavascript does not respect this setting and so I > get messages like "The field ???en_US.responseOption.questionTypeId??? is > required.". > ValidatorTool.getDynamicJavascript first gets the global message bundle and > re-uses it for all of the error messages emitted by the javascript generator: > String message = Resources.getMessage(messages, locale, va, > field); > In order to respect the <msg>'s bundle, the code should instead be this: > String message = Resources.getMessage(app, > request, > messages, > locale, > va, > field); > It turns out that this doesn't fix the problem, although I'm sure that this > change should be made. Perhaps someone with a better understanding of > Struts/Validator/VelocityTools could shed some light on this situation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
