On 9/16/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: henning
Date: Sat Sep 16 03:31:11 2006
New Revision: 446846
URL: http://svn.apache.org/viewvc?view=rev&rev=446846
Log:
A hard to see bug. At the location of the (left == null ? 0 : 1),
left never could be null, because this has been tested earlier.
Actually meant was left.toString() == null, which also should not
happen (the contract of toString() normally forbids it), but nevertheless
fix the problem. Suggested by FindBugs.
Just for the record, i agree with fixing this problem. I feel we
should always consider the possibility of toString() returning null
when we are working in the Velocity world. While the contract of
toString() does normally forbid it, Velocity's high dependence on
toString() makes it unwise to trust programmers to know this, regard
it and successfully follow it.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
