On 26/01/13 16:47, Jeremy Sanders wrote: > On 26/01/13 17:23, Dave Hughes wrote: > >> Jeremy might have a better method, but I see what you mean about the >> fill above/below functions operating on a horizontal basis. I'm guessing >> getting this working in Veusz "natively" would require adding fill >> left/right functions as well. I might see if I can dig into the code and >> figure that out in a bit... > > Hi Dave - I'm thinking there might be too many options to have > Above/Below/Left/Right added.
Yup, I think I agree. I finished implementing it for the point plot and the resulting interface is more than a little cluttered (not to mention redundant given that the above+left, and below+right fills at least partially overlap). I'm also none to sure how to proceed with things like the error fills (the diamond one in particular has me rather confused). Oh well. > I wonder whether it would be better to change Below/Above to > Fill1/Fill2 and to have an option for each saying to which edge to > fill to (like for the polar/ternary plot). That way you could add > things like fill centre/topleft/topright... if it would be useful. That sounds more reasonable. So, to get this straight in my head: the PointFill class in settings.collections would gain an extra attribute (based on settings.controls.Choice presumably) called, say, "edge" which could accept "left", "right", "top", "bottom". Then widgets.points._drawPlotLine gets re-written to figure out the polygon that needs constructing to fill to the specified edge, and likewise for _drawBezierLine (doubt it'll be difficult; it wasn't for a FillLeft and FillRight implementation). I'll have to have a longer play with the error-bar handling to figure out the necessary alterations to _errorBarsBoxFilled and _errorBarsDiamondFilled. > I'd need to translate the original fills to the old (for backward > compatibility). Hmm, that bit I've no idea about. Is there already some code for handling on-the-fly translation of deprecated settings somewhere in Veusz? I've not run across it yet... If I can come up with something workable I'll bung over another pull request in GitHub. Cheers, Dave. _______________________________________________ Veusz-discuss mailing list [email protected] https://mail.gna.org/listinfo/veusz-discuss
