Revision: 1754
http://svn.sourceforge.net/vexi/?rev=1754&view=rev
Author: mkpg2
Date: 2007-03-26 09:10:19 -0700 (Mon, 26 Mar 2007)
Log Message:
-----------
Fix. array.reverse() was broken!!
Modified Paths:
--------------
core/trunk/org.ibex.js/src_junit/test/js/array/testsort.js
core/trunk/org.ibex.util/src/org/ibex/util/Basket.java
Added Paths:
-----------
core/trunk/org.ibex.js/src_junit/test/js/array/lib.js
core/trunk/org.ibex.js/src_junit/test/js/array/reverse.js
Added: core/trunk/org.ibex.js/src_junit/test/js/array/lib.js
===================================================================
--- core/trunk/org.ibex.js/src_junit/test/js/array/lib.js
(rev 0)
+++ core/trunk/org.ibex.js/src_junit/test/js/array/lib.js 2007-03-26
16:10:19 UTC (rev 1754)
@@ -0,0 +1,8 @@
+
+export.strToArray = function(str){
+ var r = [];
+ for(var i=0; i<str.length; i++){
+ r[i] = str.charAt(i);
+ };
+ return r;
+};
\ No newline at end of file
Added: core/trunk/org.ibex.js/src_junit/test/js/array/reverse.js
===================================================================
--- core/trunk/org.ibex.js/src_junit/test/js/array/reverse.js
(rev 0)
+++ core/trunk/org.ibex.js/src_junit/test/js/array/reverse.js 2007-03-26
16:10:19 UTC (rev 1754)
@@ -0,0 +1,6 @@
+sys.import("shared");
+sys.import("lib");
+assertEquals("a",["a"].reverse().join());
+assertEquals("ba",["a","b"].reverse().join(""));
+assertEquals("321cba",strToArray("abc123").reverse().join(""));
+assertEquals("leahcim",strToArray("michael").reverse().join(""));
Modified: core/trunk/org.ibex.js/src_junit/test/js/array/testsort.js
===================================================================
--- core/trunk/org.ibex.js/src_junit/test/js/array/testsort.js 2007-03-26
15:52:10 UTC (rev 1753)
+++ core/trunk/org.ibex.js/src_junit/test/js/array/testsort.js 2007-03-26
16:10:19 UTC (rev 1754)
@@ -1,10 +1,4 @@
-var strToArray = function(str){
- var r = [];
- for(var i=0; i<str.length; i++){
- r[i] = str.charAt(i);
- };
- return r;
-};
+sys.import("shared");
var assertEqual = function(a,b){
var stra = a.join();
Modified: core/trunk/org.ibex.util/src/org/ibex/util/Basket.java
===================================================================
--- core/trunk/org.ibex.util/src/org/ibex/util/Basket.java 2007-03-26
15:52:10 UTC (rev 1753)
+++ core/trunk/org.ibex.util/src/org/ibex/util/Basket.java 2007-03-26
16:10:19 UTC (rev 1754)
@@ -117,7 +117,12 @@
public void reverse() {
Object tmp;
- for (int i=0; i < size; i++) { tmp = o[i]; o[i] = o[size - i];
o[size - i] = tmp; }
+ if(size==1) return;
+ int last = size - 1;
+ for (int i=0; i < (size/2); i++) {
+ tmp = o[i];
+ o[i] = o[last - i];
+ o[last - i] = tmp; }
}
public void sort(CompareFunc c) { sort(this, null, c, 0, size-1); }
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Vexi-svn mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/vexi-svn