On Fri, Dec 02, 2005 at 09:19:00AM +0000, Kailash Sethuraman wrote: > > > I propose that any further changes to valgrind, by us should be > > > encapsulated in > > > /* vg4nbsd */ > > > /* !vg4nbsd */ comments. > > > We may work on arch indep things, so VGO_netbsdelf2 ifdefs may always > > > not indicate where our changes are. This makes us clear when we have > > > changed logic. > > > Lets do this going forward? > > > > Is this really necessary? We should let our tools do this for us. For > > example, we could tag (copy to /tags) after we finish synching with a > > version of Valgrind main code. Then we can simply do svn diff on the > > trunk and the tag to see what has changed in between. > > > > > What are your thoughts on this? > > > Sounds like a plan. However will it be easily visible when we do the next > sync? > Rather than doing an svn diff to check and then check against another diff?
I don't think that's possible. AFAIK it is required to do svn diff and then diff against the new Valgrind. So on second thought, that's not an acceptable option. I guess we'll have to do it your way, by marking those spots with comments. Peter -- http://www.student.ru.nl/peter.bex -- "The process of preparing programs for a digital computer is especially attractive, not only because it can be economically and scientifically rewarding, but also because it can be an aesthetic experience much like composing poetry or music." -- Donald Knuth
pgp3ZJtcq61Rh.pgp
Description: PGP signature
