> There are a few things to improve. struct v4l2_standard isn't used
> elsewhere anymore (the videodev helper functions don't count), we can
> merge that in. Second s/v4l2_enumstd/v4l2_standard following v4l2_input,
> v4l2_tuner etc. w/o "enum" in the name. Third I propose to add
> .standardset in v4l2_input/v4l2_output and remove the .input/outputset
> here. Rationale is that we have the .tuner link and .audioset there too.
> This change would root everything in the input/output enum.
Done.
> Shouldn't this be more consistent? What about index everywhere to
> emphasize the function, or enumeration names (v4l2_audio.audio,
> v4l2_input.input) to clarify these are unrelated? Or just
> v4l2_enumstd.inputset -> v4l2_input.index; v4l2_input.audioset ->
> v4l2_audio.index, v4l2_input.tuner and v4l2_frequency.tuner ->
> v4l2_tuner.index etc. you see the pattern.
Consistent naming is allways a good thing. Walked through the file,
hope I catched them all.
Gerd
--
You can't please everybody. And usually if you _try_ to please
everybody, the end result is one big mess.
-- Linus Torvalds, 2002-04-20
_______________________________________________
Video4linux-list mailing list
[EMAIL PROTECTED]
https://listman.redhat.com/mailman/listinfo/video4linux-list
