On Tue, 2002-10-22 at 19:41, Gerd Knorr wrote:
> The whole thing is rushed out a bit and not tested that much.  It is
> basically working, but likely needs alot of minor tweaks here and there.

You're quick! Nice work, Gerd. Thanks!

> Comments? Bugs? Crashes?

Some small blabla:

v4l2-common.c:
MODULE_AUTHOR("Bill Dirks, Justin Schoeman, Justin Schoeman, Gerd
Knorr");

I assume everyone needs to know him, but why is Justin listed twice?

Now, something special... I had a look at v4l2_clip and video_clip
(v4l1), and unfortunately, thet two are not binary compatible. I know
this is not right to ask, but I'll still ask so: could they please be
made binary compatible?

struct v4l2_rect {
        __s32   left;
        __s32   top;
        __u32   width;
        __u32   height;
};

would then become:

struct v4l2_rect {
        __s32   left;
        __s32   top;
        __s32   width;
        __s32   height;
};

this just makes driver and v4l1/v4l2-compatible application programming
a bit easier, imho. Besides that, it has no goal.

Besides that, I'll be happy to see this thing going into 2.5.x.

Ronald



_______________________________________________
Video4linux-list mailing list
[EMAIL PROTECTED]
https://listman.redhat.com/mailman/listinfo/video4linux-list

Reply via email to