>  Here's a patch against 2.4.4 that integrates those files into the
>  kernel.
>  
>  ftp://ftp.thedirks.org/pub/v4l2/kernel2.4/patch-v4l2-2.4.4.gz

bugfix below:  IMHO the copying back to userspace should _not_ be done
if the driver flags an error.

  Gerd

PS: /me runs 2.4.4-ac kernels right now.  If someone needs a v4l2 patch
    for those kernels drop me a note, I can build one if needed.

-------------------------- cut here ------------------------
--- drivers/media/video/v4l2-common.c~  Sat May  5 09:58:34 2001
+++ drivers/media/video/v4l2-common.c   Mon May  7 10:58:34 2001
@@ -133,6 +133,9 @@
                        inode, file, cmd, parg);
        }
 
+       if (err < 0)
+               return (err == -ENOIOCTLCMD) ? -EINVAL : err;
+
        /*  Copy results into user buffer  */
        switch (_IOC_DIR(cmd))
        {
@@ -148,11 +151,7 @@
                break;
        }
 
-       if (err != -ENOIOCTLCMD)
-               return err;
-
-       /*  Handle ioctls not recognized by the driver  */
-       return -EINVAL;
+       return err;
 }
 
 /*



_______________________________________________
Video4linux-list mailing list
[EMAIL PROTECTED]
https://listman.redhat.com/mailman/listinfo/video4linux-list

Reply via email to