On Sat, Mar 29, 2008 at 8:44 PM, Bram Moolenaar <[EMAIL PROTECTED]> wrote: > > > Andrei Aiordachioaie wrote: > > > On Mar 20, 1:30 pm, Bram Moolenaar <[EMAIL PROTECTED]> wrote: > > > > > > Let's do the fast regexp work first. It's easy to underestimate how > > > much work this stuff is. > > > > I looked at the updated regexp code that Xiaozhou Liu has maintained, > > and it looks a lot closer to being included. The problems I see so far > > with the new engine are: > > - the three test cases that fail, but of course there may be more bugs > > - compatibility with the old engine. > > > > >From what I've looked at the test-cases, it seems that the NFA > > implementation is not greedy, as it should be. I will look more into > > it. > > > > So for the project, I want to extend the test-suite to compare the way > > regexps are handled in the old vs the new engine. Maybe this uncovers > > other bugs. Then, the largest portion of the project would be fixing > > the found bugs. And if that takes little time, I could work on the old > > regexp engine bugs. Do you have any other ideas? Would this be enough > > for a 2.5 months project? > > Another big task is to merge the code, removing things that were > duplicated. My current idea is to first move everything into regexp.c, > then remove the duplicated stuff,
I have done this. Everything is in regexp.c and there is no duplication. > then clean it up and perhaps move the > two engines to separate files. This should be done in small steps, > making sure everything still works after each step. I think it is diffcult to move the two engines to separate files because they have a lot to share. It's better to keep them in regexp.c. Xiaozhou --~--~---------~--~----~------------~-------~--~----~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~----------~----~----~----~------~----~------~--~---
