On Fri, Nov 13, 2009 at 6:08 PM, James Vega <james...@jamessan.com> wrote: > On Fri, Nov 13, 2009 at 10:39:29PM +0100, Bram Moolenaar wrote: >> Tim Starling wrote: >> > Thus by calling g_main_context_iteration() at the relevant places, vim >> > can leave main_loop() unmodified. >> > >> > My patch does this, and removes all calls to gtk_main_quit() except the >> > ones in modal dialogs. Modal dialogs are now implemented by calling >> > gtk_main() once only, and allowing the button handlers to call >> > gtk_main_quit(), just like in a regular GTK application. >> > [...] >> > Of course we miss out on that final >> > sync of recently-used.xbel, but it seems that it's already synced every >> > time it's changed, via the "changed" signal (see >> > gtk_recent_manager_changed() and its callers in gtk/gtkrecentmanager.c). >> >> I'm very glad to see someone is picking up a GTK problem. Hardly any >> work was done on GTK for a long time. >> >> I would appreciate it if a few people try this out and report any >> problems they notice. > > The bug Tim fixed was something I had been planning on taking a look at, so > I'll definitely try out the patch soon and report back.
I've given it a shot and it's working well for me. One thing I did notice is that the files Vim edits aren't added to Gtk's recently used list. Based on the patch, this doesn't look like it's a regression in behavior from the last time Vim was using GtkFileChooser. I think it'd be good to get the patch as is included so Vim is no longer using a deprecated (and as of Gtk3 removed) widget. Also, GtkFileChooser is more intuitive to use than GtkFileSelection (where it's non-obvious how to select hidden files). It would be interesting to look into how (and whether) Vim should make use of Gtk's recently used list, especially since not all of Vim's buffers directly relate to an actual file. -- James GPG Key: 1024D/61326D40 2003-09-02 James Vega <james...@jamessan.com> --~--~---------~--~----~------------~-------~--~----~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~----------~----~----~----~------~----~------~--~---
