On 2011/4/14 3:05, Dominique Pellé wrote:
Hi

Attached patch fixes a bug in vim_getenv() found
with cppcheck static analyzer:

$ cd vim/src ; cppcheck -f -I proto misc1.c
[misc1.c:3956]: (error) Possible null pointer dereference: mustfree -
otherwise it is redundant to check if mustfree is null at line 3953

Reading the code, I'd expect invalid memory free to possibly happen
on Windows. I don't have a Windows computer to test it, but
the patch is simple anyway.

So the line below, which is "*mustfree = TRUE;", should be useless?

Regards,
Hong Xu
2011/4/14

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

Reply via email to