Brain D. Burns wrote: > On 07/08/2012 07:49 PM, Brian D. Burns wrote: > > On 07/07/2012 09:57 AM, Bram Moolenaar wrote: > >> > >> Brian Burns wrote: > >> > >>> Recently, I have been looking into different methods for using Vim > >>> to syntax highlight small blocks of code. In the process, I found > >>> runtime/tools/xcmdsrv_client.c, which worked but seemed a little > >>> outdated. So, after working with this a bit, I decided to create a > >>> Ruby extension from src/if_xcmdsrv.c. > >>> https://github.com/burns/vim_client-ruby > >>> This is the most I've ever done in C, so it was quite the learning > >>> experience. So, comments/suggestions are certainly welcome :) > >>> > >>> While working with this, I found a few things I wanted to submit > >>> for changes in if_xcmdsrv.c. I've attached 3 patches, which include > >>> my comments. > >>> > >>> if_xcmdsrv.patch.1 was a duplicate call to ga_init2. > >>> > >>> if_xcmdsrv.patch.2 deals with the fact that the server is actually > >>> sending a response to clients making input key requests (--remote-send), > >>> even though they don't expect one, and some other thoughts. > >>> > >>> if_xcmdsrv.patch.3 suggests some changes to the ServerWait() function, > >>> which speeds up response time, handles an issue where the XEvent queue > >>> is not being checked when 'localLoop' is true, and a few other thoughts. > >>> > >>> I appreciate your time - and Vim! :) > >> > >> It looks like you know what you are doing. I appreciate taking the time > >> to improve this code, it hasn't been worked on for a while. I'll look > >> into the details later. > >> > >> While you are digging into this, could you find some way to test this > >> code? This might be complicated, since it requires starting two Vim > >> instances talking to each other, but it would be very useful to have at > >> least basic testing for this code. > >> > >> > > > > Hey, > > > > I've attached some basic tests. > > I'm not sure if what I'm doing here would work on all systems, > > but it's a start. Let me know what you think. > > > > - Brian > > Small change. I meant to keep remote_read() from being called > if remote_peek() didn't see a message, so it won't block.
Thanks. I'll look into it when I have some time. -- hundred-and-one symptoms of being an internet addict: 94. Now admit it... How many of you have made "modem noises" into the phone just to see if it was possible? :-) /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php