On 2013-05-08 20:32:01, Christian Brabandt wrote:
> Hi Eric!
>
> On Mi, 08 Mai 2013, Eric Van Dewoestine wrote:
>
> > On 2013-05-08 07:40:06, Christian Brabandt wrote:
> > > On Wed, May 8, 2013 00:15, Ben Fritz wrote:
> > > > The maintainer of Eclim, Eric Van Dewoestine, sent me a patch to try
> > > > once
> > > > which not only allowed setting the quickfix title but it also made
> > > > :colder
> > > > and :cnewer restore that title.
> > > >
> > > > I can't tell from looking quickly, does your patch allow this as well?
> > >
> > > Yes, this automatically happens, if a quickfix list contains a title.
> > > Looking at that patch, it seems, it introduces some new functions
> > > setqftitle()/getqftitle() I am not sure this is needed, since you can
> > > simply set and query the variable w:quickfix_title
> >
> > The problem with setting w:quickfix_title directly is that the title
> > is not properly stored with the list and so it's lost when using
> > cnewer/colder.
> >
> > The advantage of having separate functions is that you can set the
> > title without having to replace the existing list:
> >
> > call setqftitle('something meaningful')
> > vs
> > call setqflist(getqflist(), 'r', 'something meaningful')
> >
> > However, while testing your patch it seems I can't overwrite the
> > existing title to make it something more meaningful when using replace
> > ('r') or append ('a'). In those cases the argument seems to be
> > ignored. So when making use of cexpr to build my quickfix list, I'm
> > still stuck with the default title vim generates or setting
> > w:quickfix_title directly and losing that title when navigating the
> > quickfix lists history.
> >
> > I'm not dead set on having separate functions like in my patch, but
> > not being able to update the persistent title of an existing list
> > makes your patch far less useful in my usage. Can that aspect be
> > remedied?
>
> Please try the updated patch.
Works much better now, thank you.
> I haven't yet created on extra functions,
> but if this is preferred, I'll change it. Opinions?
I'm fine with using setwinvar instead of having dedicated functions.
It avoids the need for an exists() call to retain backwards
compatibility in scripts.
> Mit freundlichen Grüßen
> Christian
--
eric
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
