четверг, 30 мая 2013 г., 17:39:19 UTC+4 пользователь Bram Moolenaar написал:
> I have included all the Python patches that ZyX sent.
This hunks are present in the python-extended-3-fixed branch, but missing in
your patches:
# HG changeset patch
# User ZyX <kp-...@ya.ru>
# Date 1369938812 -14400
# Branch python-extended-4
# Node ID b16cc3931caec2373abc5eac9396f88aac318e80
# Parent 1a4b98208569a60fab5662e02077aa3d3b62193b
Missing changes
diff -r 1a4b98208569 -r b16cc3931cae src/if_py_both.h
--- a/src/if_py_both.h Thu May 30 19:18:31 2013 +0200
+++ b/src/if_py_both.h Thu May 30 22:33:32 2013 +0400
@@ -4528,7 +4528,7 @@
PyObject *valObject;
Py_ssize_t iter = 0;
- if (!(dict = dict_alloc()))
+ if (!(dict = py_dict_alloc()))
return -1;
tv->v_type = VAR_DICT;
@@ -4600,7 +4600,7 @@
PyObject *keyObject;
PyObject *valObject;
- if (!(dict = dict_alloc()))
+ if (!(dict = py_dict_alloc()))
return -1;
tv->v_type = VAR_DICT;
It is essential as py_dict_alloc increments reference count for dictionaries
that are then decremented and thus cause the crash. Even with this patch tests
for errors are still failing though, but there are no crashes.
> Unfortunately the current status is that Vim crashes while running tests
> 86 and 87. I'm sending out a patch to disable these tests so that I can
> continue with other work.
>
> Obviously the crash should be fixed ASAP. I tried syncing back to a
> previous version, and it appears to crash first with 7.3.1056.
> But I'm not sure, valgrind reports errors much further back, so there
> might be crashes even before that, depending on random factors.
>
> ZyX - I hope you can fix the crashes, and possibly all valgrind errors.
> Memory leak problems can be solved later, but we definitely don't want
> memory access errors.
>
> Patch 7.3.1044 adds the .valid field, but there still is no
> documentation for it.
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
