Nobuhiro Takasaki wrote:

> It is a thing that this also solved the Issues of Japanese.
> 
> I will read through the TODO after this. I fun.
> 
> https://gist.github.com/ntak/8936239

I would prefer the patch in the email message, so that I don't need to
navigate to a web page to see what it's about.

The check for has_mbyte needs to stay where it is.

   p = mb_unescape(&p);

I don't think it is a good idea to change p both as as the argument and
as the target of assignment.  Using two pointers is better.

Can you write a test for this?

-- 
GALAHAD: No. Look, I can tackle this lot single-handed!
GIRLS:   Yes, yes, let him Tackle us single-handed!
                 "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Raspunde prin e-mail lui