Hi Bram! On Mi, 25 Jun 2014, Bram Moolenaar wrote:
> > Christian wrote: > > > > > Finally a new patch, here we go: > > [...] > > > Thanks, much better now. > > > > Let me include it and make a few small improvements. I'm sure we will > > discover more problems once more people use the feature, I hope you will > > fix these problems then! > > I already found and fixed a few problems. > > When starting Vim the default values for the 'briopt' option are not > used. > > The documentation says that the default for the minimum is 20, but the > implementation uses a default of 0. A default of 20 is much more > useful, so let's use that. I had to change the tests to compensate. > Now we might as well make the default value empty. Huh? The default for briopt was 'shift:0,min:20' which should actually use 20. Using an empty value for briopt will make Vim always use 20, if min is not set, even if explicitly making briopt empty. That is at least unexpected. I think, this also causes the needed change to the ok file (infact, the idea was, that the computed length and the length of strdisplaywidth should be the same). > I added TODO items in places where I did not understand the code, mainly > failing to pass in the start of the line, thus computing indent on > somewhere halfway a line. If the pointer doesn't matter we better pass > NULL, so it's clear we do not compute the indent. If it does matter I > suspect there are situations where the column is not computed correctly. > > Please have a look at these added TODO items. I will. You are probably right about those TODO items. I need to check that first, however. Best, Christian -- Steigt Rauch aus meinem Tower, werd' ich lieber Bauer. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
