Christian Brabandt wrote:
> On Do, 10 Jul 2014, Bram Moolenaar wrote:
> > Danek Duvall wrote:
> >
> > > On Wed, Jul 02, 2014 at 08:01:04PM +0200, Bram Moolenaar wrote:
> > >
> > > >
> > > > Patch 7.4.353
> > > > Problem: 'breakindent' doesn't work with the 'list' option.
> > > > Solution: Make it work. (Christian Brabandt)
> > > > Files: runtime/doc/options.txt, src/charset.c, src/screen.c,
> > > > src/testdir/Make_amiga.mak, src/testdir/Make_dos.mak,
> > > > src/testdir/Make_ming.mak, src/testdir/Make_os2.mak,
> > > > src/testdir/Make_vms.mms, src/testdir/Makefile,
> > > > src/testdir/test_listlbr.in, src/testdir/test_listlbr.ok
> > >
> > > When the tests are run with LC_ALL=C, this test fails, apparently because
> > > test_listlbr.out ends up having converted the various unicode characters
> > > to
> > > something other than utf-8, and so it doesn't match the .ok file. AFAICT,
> > > this is the only test with that problem (at least, it's the only test that
> > > fails for me).
> > >
> > > Running the tests in a utf-8 locale isn't really an option for me, but I'm
> > > not sure what the right answer actually is. Should the test be modified
> > > to
> > > not require "fancy" unicode characters, or should the test suite be sure
> > > to
> > > run this particular test to force utf-8 encoding (assuming the system is
> > > even configured with it)? Or is there some other option?
> >
> > Well, I suppose we do want to test if the feature works with those
> > characters. So perhaps just forfeit the test on systems without utf-8?
>
> How about the attached patch? It checks, if Vim is running in utf-8 mode
> and if not skips 2 checks.
I do not really like the idea of two versions of the .ok file. It's a
new mechanism and will easily confuse me. Does testing without utf-8
have a good purpose? Then I would prefer to split this up in two
tests, so that when utf-8 is supported the test is also run without
utf-8. If testing without utf-8 isn't really useful I would prefer to
just skip it.
--
LAUNCELOT: Isn't there a St. Aaaaarrrrrrggghhh's in Cornwall?
ARTHUR: No, that's Saint Ives.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
