This unused two characters-wide sign column wastes space, take for example a
screen that is vertically splitted to show multiple buffers. The attached
patch fixes this.
For reference, a link to the pyclewn issue tracker that raised the issue:
https://bitbucket.org/xdegaye/pyclewn/issue/7
Patch side effects on a debugger using netbeans:
* When browsing the source code with this patch, the presence of a sign column
tells you that either a breakpoint or the frame sign is set in this buffer,
even when you don't see the sign itself. This is a useful indication (lost
when all windows have a sign column).
* The command 'step' or 'next' causes the sign column to disappear and a
reappear rapidly when there are no breakpoints and causes all the lines to
be shifted rapidly left and right. For example at a sleep() statement the
sign column disappears for the duration of the sleep. This may be
considered annoying and may be the reason why netbeans currently forces the
sign column in all the windows.
About the patch:
A two characters wide space at the start of the command line is not accessible
after netbeans has set the first sign and remains inaccessible even after
':nbclose'. This minor problem already exists currently and is not fixed by
the patch.
For backward compatibility we could use an option to choose between the two
behaviors, I don't know which option, maybe an option in the nbstart command
as in :{hostname}:{addr}:{password}:{sign column} or a netbeans command or an
existing Vim option ?
-- Xavier
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
diff --git a/src/edit.c b/src/edit.c
--- a/src/edit.c
+++ b/src/edit.c
@@ -6680,11 +6680,7 @@
textwidth -= curwin->w_p_fdc;
#endif
#ifdef FEAT_SIGNS
- if (curwin->w_buffer->b_signlist != NULL
-# ifdef FEAT_NETBEANS_INTG
- || netbeans_active()
-# endif
- )
+ if (curwin->w_buffer->b_signlist != NULL)
textwidth -= 1;
#endif
if (curwin->w_p_nu || curwin->w_p_rnu)
diff --git a/src/move.c b/src/move.c
--- a/src/move.c
+++ b/src/move.c
@@ -902,12 +902,7 @@
+ wp->w_p_fdc
#endif
#ifdef FEAT_SIGNS
- + (
-# ifdef FEAT_NETBEANS_INTG
- /* show glyph gutter in netbeans */
- netbeans_active() ||
-# endif
- wp->w_buffer->b_signlist != NULL ? 2 : 0)
+ + (wp->w_buffer->b_signlist != NULL ? 2 : 0)
#endif
);
}
diff --git a/src/screen.c b/src/screen.c
--- a/src/screen.c
+++ b/src/screen.c
@@ -2212,11 +2212,7 @@
draw_signcolumn(wp)
win_T *wp;
{
- return (wp->w_buffer->b_signlist != NULL
-# ifdef FEAT_NETBEANS_INTG
- || netbeans_active()
-# endif
- );
+ return (wp->w_buffer->b_signlist != NULL);
}
#endif
