James Kolb wrote: > The current regex code may call mch_breakcheck which can process X events. > One of these events could be a remote_expr that makes its own call into the > regex engine. This usually crashes because the regex engine isn't > reentrant. This is probably also a problem for anything else that runs long > enough to make breakchecks and isn't reentrant. > > This crash can usually be reproduced in linux by running vim with a > --servername argument and typing the command: > :call system("sleep 1 && vim --servername ".v:servername." --remote-expr > 'substitute(string(range(5000)), \"a\", \"b\", \"g\")' &") | call > substitute(string(range(5000)), '\(,.*\)\@<!,', '', 'g') > > The attached patch fixes the problem by preventing RealWaitForChar from > processing X events if it is called from mch_breakcheck.
Thanks for the patch. However, I think the proper solution would be to make the regexp code reentrant. That means getting rid of the global variables. It's been messy like that for a long time. I think your patch fixes one specific situation, but it can happen in other situations as well. -- LAUNCELOT: Isn't there a St. Aaaaarrrrrrggghhh's in Cornwall? ARTHUR: No, that's Saint Ives. "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.