On 15/02/2016 12:09, Bram Moolenaar wrote:
Mike Williams wrote:
Come on guys, if you're fixing code dependent on pp defines, check with
them both defined and undefined that everything still builds and links.
It appears Appveyor only builds one specific setup. It would be useful
to run a few more combinations. I can't possibly check more than a few
things, especially if it involves MS-Windows (with at least four
combinations: GUI/console * MSVC/MingW).
The only combination relevant here is if FEAT_CHANNEL is defined or not.
If someone writes code that depends on a PP symbol I would hope they
would check compiles with it defined and undefined. They should not be
relying on a CI server to catch these basic mistakes IMHO. (Sorry, it's
a Monday.)
Anyway, I prefer the solution I sent in the patch with #else. A bit
easier to see what's happening.
Technically, it is not to keep the compiler happy but to write correct C
code. There is a reason why goto has a bad reputation. ;-)
TTFN
Mike
--
This is certainly more fun than being hit with a hammer.
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
