Kazunobu Kuriyama wrote:
> I'm going to report a bug on the feature termtruecolor and propose a minor
> modification to its implementation.
>
> 1. Bug
>
> Probably, the bug is most easily reproduced with the command:
>
> $ vim -N -u guicolors-test.vim -c 'runtime syntax/colortest.vim'
>
> on a true color capable terminal, where guicolors-test.vim is
>
> set t_8f= ^[[38;2;%lu;%lu;%lum
> set t_8b= ^[[48;2;%lu;%lu;%lum
> set guicolors
> syntax on
>
> (For convenience, the script is attached to this mail.)
>
> Now please have a look at the vim and compare *the* dark green with *the*
> green. You'll see the dark green is lighter than the green and the green
> itself is too dark.
>
> This is caused by the initialization with wrong values in the definition of
> the array rgb_table[] (term.c:1275).
>
> Actually, the values of dark green and green are initialzied to #008000 and
> #006411 respectively there, and thus the result above.
>
> The patch corrects the values and sets green and dark green to #00FF00 and
> #006400, respectively. Those values come from runtime/rgb.txt.
Thanks. I agree that rgb.txt is the best reference for the color names.
> 2. Proposal
>
> Now that vim is true color capable, it would be reasonable to rethink the
> correspondence between color names and their corresponding RGB values in
> rgb_table[].
>
> Just like I did it for dark green and green, I think it's best to get the
> correspondence to comply with runtime/rgb.txt.
>
> By always referring to that well-known, widely-used table, we could make
> the following troublesome issues more manageable:
>
> 1. Ambiguity caused by specifying colors by their names
> 2. Confusion due to usecase-dependent discrepancies in colors, which is
> caused by a tangled combination of hardware and software in use, e.g,
> physical characteristics of the screen, color calibration by the OS, gamma
> correction of the windowing system.
>
> The attached patch includes a modification for that as well.
Thanks. I'll put back "cyan" with the right values.
--
MESKIMEN'S LAW
There's never time to do it right, but always time to do it over.
/// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
