On Windows 2000 or later, there has already been a macro called RGB [1], which conflicts with ours in term.c.
This caused a compiler warning on Windows as reported by John Marriott. Thus Patch 1795 renamed ours from RGB to TORGB to avoid the name conflict. Now we have wrong colors on Windows as reported by Christian J. Robinson. This is because, while our macro places RGB color intensities into a 32-bit integer in the order of 0x00RRGGBB, Windows' macro does it with the partially reversed order 0x00BBGGRR [2], thus causing the glitch. [1] https://msdn.microsoft.com//library/windows/desktop/dd162937(v=vs.85).aspx [2] https://msdn.microsoft.com/en-us/library/windows/desktop/dd183449(v=vs.85).aspx 2016-04-27 15:15 GMT+09:00 Ken Takata <[email protected]>: > Hi, > > 2016/4/27 Wed 15:03:06 UTC+9 Marius Gedminas wrote: > > On Tue, Apr 26, 2016 at 02:48:48PM -0600, Christian J. Robinson wrote: > > > > > > Something went wrong with this patch. Most of my colors are wrong. > > > > > > How it looks now: > > > https://www.dropbox.com/s/q8wc4vzkg8r0uj2/vimwrongcolors.png?dl=0 > > > > > > How it should look: > > > https://www.dropbox.com/s/3of53y3qdiz1xcm/vimcorrectcolors.png?dl=0 > > > > Does 7.4.1795 fix this? > > No, it doesn't. > > Regards, > Ken Takata > > -- > -- > You received this message from the "vim_dev" maillist. > Do not top-post! Type your reply below the text you are replying to. > For more information, visit http://www.vim.org/maillist.php > > --- > You received this message because you are subscribed to the Google Groups > "vim_dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
