Ken Takata wrote: > 2016/5/6 Fri 2:14:57 UTC+9 Bram Moolenaar wrote: > > Ken Takata wrote: > > > > > 2016/5/6 Fri 0:19:06 UTC+9 Bram Moolenaar wrote: > > > > Patch 7.4.1818 > > > > Problem: Help completion adds @en to all matches except the first > > > > one. > > > > Solution: Remove "break", go over all items. > > > > Files: src/ex_getln.c > > > > > > This patch has a problem when help files with multiple languages are > > > installed. > > > E.g. When @ja and @en are installed and 'helplang' is set to ja, > > > > > > :h screenrow()<C-D> > > > screenrow() screenrow() > > > > > > But this should be: > > > > > > :h screenrow()<C-D> > > > screenrow() screenrow()@en > > > > > > Or, when 'helplang' is not ja, this should be: > > > > > > :h screenrow()<C-D> > > > screenrow()@ja screenrow()@en > > > > > > @en should not be removed, when there is a same help item for another > > > language. > > > > I guess the problem is that it depends on the order, the check for a > > duplicate help tag in another language can happen after a language was > > already removed. > > Do you have any ideas to fix this? > I don't have it, but the following behavior is totally useless: > > :h screenrow()<C-D> > screenrow() screenrow()
>From the top of my head: First do the part that loops over all matches, do the other removing later. > > > BTW, I think that adding @en to all matches is harmless. > > > > Although this would be harmless, the @en should not be added when it's > > not needed, the matches look different from the actual help tag. > > Wasn't setting 'helplang' to en enough? It's initialized depending on the environment. It should not be needed for the user to set it. -- A disclaimer for the disclaimer: "and before I get a huge amount of complaints , I have no control over the disclaimer at the end of this mail :-)" (Timothy Aldrich) /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.