I wrote: > Kazunobu Kuriyama wrote: > > > 2017-03-20 5:24 GMT+09:00 Bram Moolenaar <[email protected]>: > > > > > > > > Please note that I changed the client-server test to use timeouts, > > > instead oa a timer with an abort. The main reason is that if the abort > > > kicks in there is no way to rerun the test, thus adding it to the list > > > of flaky tests has no effect. > > > > > > I also added a check if the remote server is up, by getting the value of > > > v:version. That avoids the arbitrary wait time. > > > > > > I hope you can use this to make the quotestar test more reliable. > > > > > > > So I wrote a patch following your kind suggestion. Please find an attached > > patch. Hopefully, it works well on Linux, too. > > Thanks, it passes for me, thus I'll include it.
Unfortunately it did fail on Travis once: >From test_quotestar.vim: Found errors in Test_quotestar(): First run: function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11 line 33: Expected 'yes' but got '' Second run: function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11 line 33: Expected 'yes' but got '' It did succeed in other tasks, it appears to be flaky. I have also seen the other test fail more often on Travis, probably because these machines are busy, thus delays are longer and less predictable. -- hundred-and-one symptoms of being an internet addict: 172. You join listservers just for the extra e-mail. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
