2017-04-09 21:58 GMT+09:00 Bram Moolenaar <[email protected]>: > > Kazunobu Kuriyama wrote: > > > When vim is build on macOS with --disable-darwin, test_normal fails. > > > > The test is intended to skip itself on Mac; however, the condition > > "!has('mac')" does not cover the case of the mentioned build, thus > failing > > to work as intended for it. > > > > The attached patch fixes that by adding "&& !has('osx')" to the condition > > for the skip. > > Thanks. We should make the feature list a bit more clear about what > those features mean.
We definitely need that. If you are OK, let me look into that, though it will take days or a week for me to come to a conclusion and write a patch. Any ideas or thoughts on this issue are absolutely welcome. I now have: > > gui_mac Compiled with Macintosh GUI. > mac Any Macintosh version of Vim, but not all OS X. > macunix Compiled for OS X, with darwin > osx Compiled for OS X, with or without darwin > > Is that right? > That's right. > > Since this test is about the isupper() and islower() in the library, > perhaps only checking for "osx" is sufficient? > I think so. While 'mac' includes the case of MACOS_CLASSIC which is defined in vim.h when 'macintosh' , which is seemingly not used for any build nowadays, is defined, 'osx' applies to all possible builds for the platform known as Mac OS X, OS X, and mac OS... Kazunobu > -- > GALAHAD: No. Look, I can tackle this lot single-handed! > GIRLS: Yes, yes, let him Tackle us single-handed! > "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES > LTD > > /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net > \\\ > /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ > \\\ > \\\ an exciting new programming language -- http://www.Zimbu.org > /// > \\\ help me help AIDS victims -- http://ICCF-Holland.org > /// > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
