Ken Takata wrote:
> I found memory leakage in term_and_job_init() on Win32.
> I also added a workaround when AssignProcessToJobObject() failed.
> This the same
> as mch_job_start() in os_win32.c and would be useful on Windows 7 or earlier.
> Please check the attached patch.
Thanks. Looks like spawn_config also needs to be freed after "failed:".
> @@ -1227,7 +1228,12 @@ term_and_job_init(term_T *term, int rows
> goto failed;
>
> if (!AssignProcessToJobObject(jo, child_process_handle))
> - goto failed;
> + {
> + /* if failing, switch the way to terminate
> + * process with TerminateProcess. */
> + CloseHandle(jo);
> + jo = NULL;
> + }
Shouldn't it goto failed here?
--
This sentence is not sure that it exists, but if it does, it will
certainly consider the possibility that other sentences exist.
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
