[patch] Make terminal cursor blinking on Windows by default

[Ken Takata]

Hi,

Blinking cursor was disabled by the patch 8.0.0981, however I think it should
be enabled on Windows.  Because Windows Command Prompt uses blinking cursor by
default, and also gvim.exe uses blinking cursor by default.
What do you think?

Additionally, I found a mistake in the patch 8.0.0921.  entry.blinkon is set
twice, but the second one should be entry.blinkoff.

Please check the attached patch.

Regards,
Ken Takata

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

# HG changeset patch
# Parent  afe6343ff3bbf08bb8f6d879bdc2952f22e5dc91

diff --git a/src/terminal.c b/src/terminal.c
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -1291,7 +1291,7 @@ term_get_cursor_shape(guicolor_T *fg, gu
     {
 	entry.blinkwait = 700;
 	entry.blinkon = 400;
-	entry.blinkon = 250;
+	entry.blinkoff = 250;
     }
     *fg = gui.back_pixel;
     if (term->tl_cursor_color == NULL)
@@ -2262,8 +2262,14 @@ create_vterm(term_T *term, int rows, int
     /* Allow using alternate screen. */
     vterm_screen_enable_altscreen(screen, 1);
 
-    /* We do not want a blinking cursor by default. */
+#ifndef _WIN32
+    /* We do not want a blinking cursor by default (except on Windows). */
     value.boolean = 0;
+#else
+    /* We want a blinking cursor on Windows, because it is the default
+     * behavior on it. */
+    value.boolean = 1;
+#endif
     vterm_state_set_termprop(vterm_obtain_state(vterm),
 					       VTERM_PROP_CURSORBLINK, &value);
 }