On Saturday, September 2, 2017 at 8:54:43 AM UTC-4, Bram Moolenaar wrote: > Manuel Ortega wrote: > > > > > Still failing on macOS: > > > > > > > > From test_terminal.vim: > > > > Found errors in Test_terminal_noblock(): > > > > function RunTheTest[24]..Test_terminal_noblock line 21: Pattern 'done' > > > > does > > > > not match 'ccccccecho > > > > ccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc' > > > > function > > > > RunTheTest[24]..Test_terminal_noblock[24]..Stop_shell_in_terminal > > > > line 3: Expected 'dead' but got 'run' > > > > Caught exception in Test_terminal_noblock(): Vim(bwipeout):E89: No write > > > > since last change for buffer 22 (add ! to override) @ function > > > > RunTheTest[24]..Test_terminal_noblock, line 29 > > > > TEST FAILURE > > > > make[2]: *** [report] Error 1 > > > > make[1]: *** [scripttests] Error 2 > > > > make: *** [test] Error 2 > > > > > > It is working on my Mac machine. Can you use ch_logfile() to find out > > > what happens? > > > > I've discovered something that might be related to the ongoing test > > failures. Even if it isn't thus related, I think it seems like incorrect > > and undesirable behavior. > > > > I've discovered that running `make test` causes Vim to dump entries into my > > bash $HISTFILE. In particular, whenever `make test` is run I can find > > lines like these in my $HISTFILE, and I sure didn't type them in myself: > > > > echo $TESTENV > > echo aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > > [...] > > > Oddly, this only seems to happen when $HISTFILE is set to a > > nonstandard location. If I leave the variable unset, bash dumps > > history into ~/.bash_history, where I do not see such lines. Perhaps > > the $HISTFILE variable is leaking into Vim, but even then I still > > don't see why (or even how) Vim could be dumping entries there. After > > all, manually doing a vim command of the form "!something" doesn't > > dump "something" into my $HISTFILE. > > Probably the history is only updated in an interactive shell. > > > I don't want those lines in my $HISTFILE, whether or not they are > > informative of why the tests are failing on macOS. > > Can you try to add this line to src/testdir/setup.vim: > > let $HISTFILE = "" > > Or: > > let $HISTFILE = getwcd() . "/hist"
I've tested both of those workarounds, and they were both successful. In neither case were any commands run inside of tests dumped to my custom $HISTFILE. Nor did they cause a ~/.bash_history to be created and populated. -Manny -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
