Kazunobu Kuriyama wrote:
> The purpose of this patch is to make it easier for devs to write tests
> having branch conditions for macOS.
>
> So far, to cover all possible builds for macOS, the correct condition is
> "has('mac') || has('osx')". Yet, unfortunately, it has been something easy
> to forget.
>
> This issue itself was discussed last May in the context of an argument on
> discontinuation of the support for the Carbon GUI, and we reached an
> agreement approving the proposed change in feature list items to address
> the issue (IIRC).
>
> In conjunction with that, I wrote a document on mac-darwin-ffeature and
> sent a patch for that to vim_dev. While the patch was included, I somehow
> forgot to send out a patch for the mentioned change.
>
> Having seen the test included with Patch 8.0.1049 failed with non-darwin
> builds, I remembered what I forgot.
>
> Attached is a patch for the proposed change. It is made against HEAD.
>
> Briefly, with the proposed patch, the relevant feature list items will
> change from:
>
> mac Any Macintosh version of Vim, but not all OS X.
> macunix Compiled for OS X, with |mac-darwin-feature|
> osx Compiled for OS X, with or w/o |mac-darwin-feature|
>
> to:
>
> mac Any Macintosh version of Vim
> macunix Compiled for OS X, with |mac-darwin-feature|
> osx Compiled for OS X, without |mac-darwin-feature|
I think the "osx" here is very confusing. It should just mean "any
version of OS X".
For the others: Is it clear how to add a check for a specific version,
no matter if Vim is before or after this change?
I'm not sure why "mac" was "not all OS X"? What was excluded, and did
anybody rely on that? It's certainly easier to understand.
Perhaps it makes sense to add "macdarwin". It's still a bit confusing
compared to "macunix", and redundant. But it's useful for code where
the darwin feature is required.
--
hundred-and-one symptoms of being an internet addict:
76. Your ISP regards you as a business partner rather than as a customer.
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
