Oh, the following is a comment I gave to the commit shown in the subject. I though this would appear in Conversation of Christian's xdiff PR (#2734), but it was singled out and sent to vim_dev for some reason. I'm not sure why it happened. For the context of my message below, please visit https://github.com/vim/vim/commit/f26446ce4900404508c0b909b0db954cb54d2a49
Thanks, Kazubnobu 2018-03-24 9:34 GMT+09:00 Kazunobu Kuriyama <vim-dev-git...@256bit.org>: > Since the inclusion of auto/config.h done just below implies that you > leave the handling of the keyword inline to the compiler, i.e., letting > it replace inline with __inline__ which replacement allows code using > inline to compile even with -std=c89 or -ansi, this line is rather > harmful and should be deleted since it breaks #define inline __inline__ > of auto/config.h. That's the cause of that miserable link error. > > I didn't think you tried to disable inline globally as there're a lot of > inline functions in system headers. Though you called it "rolling it back > for now" in #2732 (comment) > <https://github.com/vim/vim/pull/2732#issuecomment-375815326> , you > actually got it right with b667387 > <https://github.com/vim/vim/commit/b667387d4767b024adb49070d9ad846aee354c9a> > which doesn't have that particular line. I confirm that the commit resolves > the C89 issue affirmatively. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/vim/vim/commit/f26446ce4900404508c0b909b0db954cb54d2a49#commitcomment-28246309> > > -- > -- > You received this message from the "vim_dev" maillist. > Do not top-post! Type your reply below the text you are replying to. > For more information, visit http://www.vim.org/maillist.php > > --- > You received this message because you are subscribed to the Google Groups > "vim_dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to vim_dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
