Christian Brabandt wrote:
> On Mo, 11 Jun 2018, Bram Moolenaar wrote: > > > Ken Takata wrote: > > > > > 2018/6/11 Mon 8:11:18 UTC+9 Takuya Fujiwara wrote: > > > > 2018年6月11日(月) 3:01 Bram Moolenaar <[email protected]>: > > > > > > > > Takuya Fujiwara wrote: > > > > > > > > > > If I don't misunderstand, it seems has('win95') always returns 0 (no > > > > > > entry at f_eval() in evalfunc.c). > > > > > > But it remains in feature-list. > > > > > > I created a patch to remove the line. > > > > > > > > > > I think we can keep the line, since the feature did exist at some > > > > > point, > > > > > but add a remark that this will always be False. > > > > > > > > hmm, "win16" also did exist but it was removed from feature-list. > > > > so I thought this also should be removed. > > > > > > If we keep "win95" in the feature-list, we should restore not only "win16" > > > but also "dos16", "dos32" and "os2", I think. > > > > We don't need to keep old feature names listed forever, just the ones > > where a user might wonder what the name is for. E.g. when it is found > > in an (old) plugin. So it's rather arbitrary which ones we keep. > > Perhaps "dos32" is still relevant? "win16" and "dos16" are really old > > and stopped working quite a while ago. > > Not sure if the following is relevant or contributes to this discussion, > but here is what came up when searching github: > > has("win95"): 38,393 results > https://github.com/search?l=Vim+script&q=has%28%22win95%22%29+language%3A%22Vim+script%22&type=Code > > has("win16"): 70,269 results > https://github.com/search?l=Vim+script&q=has(%22win16%22)+language%3A%22Vim+script%22&type=Code That's surprising. It looks like it's mostly just used to detect MS-Windows and is used in combination of checking for win32: if has("win32") || has("win16") Since this has the highest count, let's keep this entry. > has("dos32"): 8,484 results > https://github.com/search?l=Vim+script&q=has(%22dos32%22)+language%3A%22Vim+script%22&type=Code > > has("dos16"): 8,279 results > https://github.com/search?l=Vim+script&q=has%28%22dos16%22%29+language%3A%22Vim+script%22&type=Code > > has("os2"): 5,780 results > https://github.com/search?q=has%28%22os2%22%29+language%3A%22Vim+script%22&type=Code All quite low, so let's omit these. -- hundred-and-one symptoms of being an internet addict: 31. You code your homework in HTML and give your instructor the URL. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
