Hi Bram,
2018/12/22 Sat 2:38:29 UTC+9 Bram Moolenaar wrote:
> Ken Takata wrote:
>
> > 2018/12/22 Sat 1:54:59 UTC+9 Bram Moolenaar wrote:
> > > I wrote:
> > >
> > > > > Patch 8.1.0616
> > > > > Problem: NSIS installer is outdated.
> > > > > Solution: Use modern syntax, MUI2 and make it work better. Add
> > > > > translations.
> > > > > (Ken Takata, closes #3501)
> > > > > Files: Filelist, nsis/gvim.nsi, nsis/icons/header.svg,
> > > > > nsis/icons/welcome.svg, nsis/icons/header.bmp,
> > > > > nsis/icons/un_header.bmp, nsis/icons/uninstall.bmp,
> > > > > nsis/icons/welcome.bmp, nsis/lang/danish.nsi,
> > > > > nsis/lang/dutch.nsi,
> > > > > nsis/lang/english.nsi, nsis/lang/german.nsi,
> > > > > nsis/lang/italian.nsi, nsis/lang/japanese.nsi,
> > > > > nsis/lang/simpchinese.nsi, nsis/lang/tradchinese.nsi,
> > > > > src/dosinst.c
> > > >
> > > > I now notice that these .bmp files are very big, 600 Kbyte.
> > > > Is there a way we can avoid that?
> > > > Since .bmp files are not compressed, making them smaller would help.
> > > > But a different format, such as .png, would help much more.
> > > > Can't we just use the .svg files?
> > >
> > > Now that I try it out, building the installer and running it, I find two
> > > files that are obtained from the wrong directory:
> > >
> > > File ..\vimtutor.bat
> > > File ..\README.txt
> > >
> > > These should use "..\" instead of ${VIMRT}. I'll make a patch for that.
> > >
> > > When running the gvim that was just installed, I get this error:
> > >
> > > libgcc_s.sjli-1.dll is missing
> > >
> > > But after clicking OK twice, gvim starts anyway.
> > > Looks like this comes from a MinGW built binary, but I build Vim with
> > > MSVC, so why is it needed?
> >
> > It is used from gettext (libintl-8.dll).
> > Next release of gettext from @mlocati might not require it, though.
> > See:
> > https://github.com/mlocati/gettext-iconv-windows/issues/8
>
> I checked that renaming libint-8.dll to something else avoids the
> problem.
> Perhaps we should use an older version for now then?
> I don't think we had this problem before.
I haven't changed that in the MUI2 patch, except I removed the check of
existence of libgcc_s_sjlj-1.dll. (See L569-L574 and L600-L605 in gvim.nsi.)
In the vim-win32-installer, we use
https://github.com/mlocati/gettext-iconv-windows/releases/tag/v0.19.8.1-v1.14
gettext0.19.8.1-iconv1.14-shared-32.zip .
It contains libgcc_s_sjlj-1.dll, so we need to place it as the same directory
as libintl-8.dll and libiconv-2.dll (as I wrote in nsis/README.txt).
If you place libgcc_s_sjlj-1.dll there, the runtime error won't happen.
If you don't place it there, NSIS will silently ignore it, and the runtime
error might happen.
The reason why I removed the existence check is that the next release of
gettext-iconv-windows will not require libgcc_s_sjlj-1.dll. (It has not been
released yet, though.)
> When uninstalling Vim, with the uninstaller script, and then installing
> it again, it complains that it cannot find the uninstaller. It still
> continues, but I think this should be silently skipped then.
Hmm, I haven't faced the problem.
Regards,
Ken Takata
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
