John Marriott wrote:
> On 11-Jan-2019 23:43, Bram Moolenaar wrote: > > Patch 8.1.0717 > > Problem: There is no function for the ":sign jump" command. > > Solution: Add the sign_jump() function. (Yegappan Lakshmanan, closes > > #3780) > > Files: runtime/doc/eval.txt, runtime/doc/sign.txt, > > runtime/doc/usr_41.txt, src/evalfunc.c, src/proto/sign.pro, > > src/sign.c, src/testdir/test_signs.vim > > > > > After this patch, mingw-64 (gcc 8.2.1) throws this warning if FEAT_SIGNS > is not defined: > gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 > -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -DFEAT_GUI_W32 > -DFEAT_CLIPBOARD -DFEAT_MBYTE -pipe -march=native -Wall -O3 > -fomit-frame-pointer -freg-struct-return -s evalfunc.c -o > gobjnative/evalfunc.o > > evalfunc.c:1927:1: warning: 'get_buf_arg' defined but not used > [-Wunused-function] > get_buf_arg(typval_T *arg) > ^~~~~~~~~~~ > > Surrounding the function with #if FEAT_SIGNS should fix it. However, the > attached patch (generated after patch 8.1.0724) moves the function > get_buf_arg() down to after the #if FEAT_SIGNS at line 11301, which also > does the trick. I prefer to add #ifdef and keep the function next to tv_get_buf(). We could use get_buf_arg() in more places, if we want an error message. -- "The question of whether computers can think is just like the question of whether submarines can swim." -- Edsger W. Dijkstra /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
