Elimar Riesebieter wrote:

> * Bram Moolenaar <b...@moolenaar.net> [2019-05-04 14:05 +0200]:
> 
> > 
> > Dominique wrote:
> > > Bram Moolenaar <b...@moolenaar.net> wrote:
> > > 
> > > > Elimar Riesebieter wrote:
> > > >
> > > > > compiling v8.1.1250 within a remote tmux session I get:
> > > > >
> > > > > Found errors in Test_term_mouse_double_click_to_create_tab():
> > > > > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab 
> > > > > line 38: ttymouse=xterm2: Expected 32 but got 0
> > > > > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab 
> > > > > line 41: ttymouse=xterm2: Expected ['Tab page 1', '    Xtab1', 'Tab 
> > > > > page 2', '>   [No Name]', 'Tab page 3', '    Xtab2'] but got ['Tab 
> > > > > page
> > > > > 1', '    Xtab1', 'Tab page 2', '>   Xtab2']
> > > > > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab 
> > > > > line 38: ttymouse=sgr: Expected 32 but got 0
> > > > > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab 
> > > > > line 41: ttymouse=sgr: Expected ['Tab page 1', '    Xtab1', 'Tab page 
> > > > > 2', '>   [No Name]', 'Tab page 3', '    Xtab2'] but got ['Tab page 
> > > > > 1', '    Xtab1', 'Tab page 2', '>   Xtab2']
> > > > > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab 
> > > > > line 38: ttymouse=urxvt: Expected 32 but got 0
> > > > > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab 
> > > > > line 41: ttymouse=urxvt: Expected ['Tab page 1', '    Xtab1', 'Tab 
> > > > > page 2', '>   [No Name]', 'Tab page 3', '    Xtab2'] but got ['Tab 
> > > > > page 1', '    Xtab1', 'Tab page 2', '>   Xtab2']
> > > > > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab 
> > > > > line 38: ttymouse=dec: Expected 32 but got 0
> > > > > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab 
> > > > > line 41: ttymouse=dec: Expected ['Tab page 1', '    Xtab1', 'Tab page 
> > > > > 2', '>   [No Name]', 'Tab page 3', '    Xtab2'] but got ['Tab page 
> > > > > 1', '    Xtab1', 'Tab page 2', '>   Xtab2']
> > > > > TEST FAILURE
> > > >
> > > > I tried running the tests in tmux, but it works fine for me.
> > > > Anything else that would matter?
> > > 
> > > For me the test error happens even without tmux anyway.
> > > Test always fails.
> > > I don't know why yet, but this change which comments out
> > > a few lines makes the test pass:
> > > 
> > > $ git diff test_termcodes.vim
> > > diff --git a/src/testdir/test_termcodes.vim 
> > > b/src/testdir/test_termcodes.vim
> > > index aef9814af..f6e50c2ae 100644
> > > --- a/src/testdir/test_termcodes.vim
> > > +++ b/src/testdir/test_termcodes.vim
> > > @@ -21,11 +21,11 @@ else
> > >  endif
> > > 
> > >  " netterm only supports left click
> > > -if has('mouse_netterm')
> > > -  let s:ttymouse_netterm = ['netterm']
> > > -else
> > > +"if has('mouse_netterm')
> > > +"  let s:ttymouse_netterm = ['netterm']
> > > +"else
> > >    let s:ttymouse_netterm = []
> > > -endif
> > > +"endif
> > > 
> > > Of course I'm not suggesting we do that, but this just
> > > shows that somehow 'netterm' breaks the test.
> > > 
> > > To Bram: could it be that for you  :echo has('mouse_netterm')
> > > gives 0 so the test would be disabled for you?   For me it
> > > gives 1.
> > 
> > I do have netterm support, that's how I verified the test works.
> > It also passes on CI.
> > 
> > It might be that you have other mouse support interfering.  Perhaps
> > check them all:
> >     echo 'mouse: ' .. has('mouse')
> >     echo 'mouse_dec: ' .. has('mouse_dec')
> >     echo 'mouse_gpm: ' .. has('mouse_gpm')
> >     echo 'mouse_netterm: ' .. has('mouse_netterm')
> >     echo 'mouse_pterm: ' .. has('mouse_pterm')
> >     echo 'mouse_sysmouse: ' ..has('mouse_sysmouse')
> >     echo 'mouse_sgr: ' .. has('mouse_sgr')
> >     echo 'mouse_urxvt: ' .. has('mouse_urxvt')
> >     echo 'mouse_xterm: ' .. has('mouse_xterm')
> >     echo 'mouseshape: ' .. has('mouseshape')
> > 
> > I get:
> >     mouse: 1
> >     mouse_dec: 1
> >     mouse_gpm: 0
> >     mouse_netterm: 1
> >     mouse_pterm: 0
> >     mouse_sysmouse: 0
> >     mouse_sgr: 1
> >     mouse_urxvt: 1
> >     mouse_xterm: 1
> >     mouseshape: 1
> 
> Well configure with --disable-gpm will pass the test.

Let me try installing libgpm-dev...  Yep, then I see the test failing.

> But does this makes sense on a linux system? For what is mouse_netterm
> useful for?

We should be able to make this work.  Adding gpm support should not
break any other mouse.

-- 
   Arthur pulls Pin out.  The MONK blesses the grenade as ...
ARTHUR:  (quietly) One, two, five ...
GALAHAD: Three, sir!
ARTHUR:  Three.
                 "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui