Dominique wrote:
> This part of the patch 8.1.1459 looks incorrect:
>
> *** ../vim-8.1.1458/src/screen.c 2019-06-03 22:04:17.840244968 +0200
> --- src/screen.c 2019-06-03 22:11:26.973743554 +0200
> ***************
> *** 1078,1084 ****
> + wp->w_height + wp->w_popup_padding[2] +
> wp->w_popup_border[2];
> popup_attr = get_wcr_attr(wp);
>
> ! if (enc_utf8)
> {
> border_char[0] = border_char[2] = 0x2550;
> border_char[1] = border_char[3] = 0x2551;
> --- 1078,1086 ----
> + wp->w_height + wp->w_popup_padding[2] +
> wp->w_popup_border[2];
> popup_attr = get_wcr_attr(wp);
>
> ! // We can only use these line drawing characters when 'encoding' is
> ! // "utf-8" and 'ambiwidth' is "single".
> ! if (enc_utf8 && p_ambw == 's')
> {
> border_char[0] = border_char[2] = 0x2550;
> border_char[1] = border_char[3] = 0x2551;
>
>
> It's most certainly meant to check the condition
> *p_ambw == 's' rather than p_ambw == 's'.
> otherwise it's comparing a pointer with character 's'
> which makes no sense.
Somehow I missed the compiler warning. Fixed now.
I also realized that the border characters from one popup were carried
over to the next one if this block was skipped. Also fixed.
--
>From "know your smileys":
(:-# Said something he shouldn't have
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/201906032111.x53LBxcn001805%40masaka.moolenaar.net.
For more options, visit https://groups.google.com/d/optout.
