Hi,

another textual nit-pick...

On Thu, Jul 18, 2019 at 9:43 PM Bram Moolenaar <b...@moolenaar.net> wrote:
> Patch 8.1.1714
> Problem:    Cannot preview a file in a popup window.
> Solution:   Add the 'previewpopup' option.
> Files:      runtime/doc/windows.txt, runtime/doc/options.txt, src/popupwin.c,
>             src/proto/popupwin.pro, src/option.c, src/option.h, src/ex_cmds.c,
>             src/testdir/dumps/Test_popupwin_previewpopup_1.dump,
>             src/testdir/dumps/Test_popupwin_previewpopup_2.dump,
>             src/ex_docmd.c, src/testdir/gen_opt_test.vim
>
>
> *** ../vim-8.1.1713/runtime/doc/windows.txt     2019-05-30 22:32:10.804178558 
> +0200
> --- runtime/doc/windows.txt     2019-07-18 14:23:29.638711601 +0200
> ***************
> *** 864,870 ****
> !                                               *preview-popup*
> ! Alternatively, a popup window can be used by setting the 'previewpopup'
> ! option.  When set, it overrules the 'previewwindow' and 'previewheight'
> ! settings.  The option is a comma separated list of values:
> !       height          maximum height of the popup
> !       width           maximu width of the popup

maximum width


>    */
>       static win_T *
>   popup_create(typval_T *argvars, typval_T *rettv, create_type_T type)
>   {
>       win_T     *wp;
>       tabpage_T *tp = NULL;
> !     int               tabnr = 0;
>       int               new_buffer;
>       buf_T     *buf = NULL;
> !     dict_T    *d = NULL;
>       int               nr;
>       int               i;
>
> !     if (argvars != NULL)
>       {
> !       // Check arguments look OK.

"Check that arguments look OK" looks better IMHO

Christ van Willegen

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/CA%2BOt1OxqSBDRL-LvBNSwU5c%3DA-gwX_i%2B-rVw6_rRJBg-zA9_ow%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui