Hi Bram, 2019/12/5 Thu 21:42:51 UTC+9 Bram Moolenaar wrote: > > > Ken Takata wrote: > > > 2019/12/5 Thu 6:17:35 UTC+9 Bram Moolenaar wrote: > > > > > > > > > Patch 8.1.2389 > > > Problem: Using old C style comments. > > > Solution: Use // comments where appropriate. > > > Files: src/libvterm/src/screen.c, > src/libvterm/src/unicode.c, > > > src/libvterm/src/vterm.c, src/libvterm/t/harness.c, > > > src/libvterm/include/vterm.h, src/xdiff/xdiffi.c, > > > src/xdiff/xemit.c, src/xdiff/xhistogram.c, > > > src/xdiff/xpatience.c, > > > src/xdiff/xutils.c, src/xdiff/xdiff.h, src/xdiff/xdiffi.h, > > > src/xdiff/xemit.h, src/xdiff/xinclude.h, > src/xdiff/xmacros.h, > > > src/xdiff/xprepare.h, src/xdiff/xtypes.h, > src/xdiff/xutils.h > > > > > > > Do we need to change the coding style of the files which are imported > > from other projects? > > I'll continue with the files in the src directory, and probably src/xxd. > Are there others? >
I think that libvterm and xdiff should keep the original comment style, so that we can easily keep them in sync with upstream, or send patches to upstream (if needed). Regards, Ken Takata -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/e912d8dc-b61e-4bac-ad83-18538d962e91%40googlegroups.com.
