On Sat, Feb 22, 2020 at 04:56:26PM -0500, James McCoy wrote:
> On Sat, Feb 22, 2020 at 09:21:56PM +0100, Bram Moolenaar wrote:
> >
> > James McCoy wrote:
> >
> > > On Sat, Feb 22, 2020 at 9:02 AM Bram Moolenaar <b...@moolenaar.net> wrote:
> > > >
> > > > Dominique wrote:
> > > >
> > > > > At https://buildd.debian.org/status/package.php?p=vim
> > > > > I noticed this test failure on hppa architecture:
> > > > >
> > > > > Caught exception in Test_terminal_special_chars(): Vim(bwipeout):E89:
> > > > > No write since last change for buffer 132 (add ! to override) @
> > > > > function RunTheTest[40]..Test_terminal_special_chars, line 11
> > > > >
> > > > > Line 11 in Test_terminal_special_chars() is 'bwipe'.
> > > > > It looks like we should call 'bwipe!' (with exclamation mark)
> > > > > in Test_terminal_special_chars(). Although I don't
> > > > > understand why the current buffer would have
> > > > > change in this test.
> > > >
> > > > After "term ls" finishes it should be possible to wipe out the buffer.
> > > > You might have found an actual problem, adding "!" would be ignoring
> > > > that problem.
> > >
> > > I can reproduce this on the hppa porterbox. Running the test on its
> > > own is fine. It's only when running the entire file that the error
> > > shows up. I'll see if I can narrow down what's causing the problem.
> >
> > I appreciate it. I can't reproduce. I thought of something like
> > 'fileformat' making the buffer marked as changed, but since this is also
> > a kind of Unix it's probably something else.
>
> Trimming test_terminal.vim down to just Test_terminal_shell_option() and
> Test_terminal_special_chars() reproduces the problem. Switching the
> order of those tests "fixes" the problem, although I see no reason why
> there should be any interaction.
>
> I added some debugging and it seems that, when the test fails, the
> terminal job has not finished yet.
Created PR#5685 with this fix and another set of fixes for
test_autocmd.vim.
The only remaining test failures I'm reliably seeing are these:
Failures:
From test_number.vim:
Found errors in Test_relativenumber_colors():
Run 1:
function
RunTheTest[40]..Test_relativenumber_colors[19]..VerifyScreenDump line 55: See
dump file difference: call
term_dumpdiff("testdir/failed/Test_relnr_colors_2.dump",
"testdir/dumps/Test_relnr_colors_2.dump"); difference in line 10: "|:|h|i|
|L|i|n|e|N|r|A|b|o|v|e| |c|t|e|r|m|f| @9|1@2|,|1| @8|5@1|%| "
function
RunTheTest[40]..Test_relativenumber_colors[23]..VerifyScreenDump line 55: See
dump file difference: call
term_dumpdiff("testdir/failed/Test_relnr_colors_3.dump",
"testdir/dumps/Test_relnr_colors_3.dump"); difference in line 10: "|:|h|i|
|L|i|n|e|N|r|B|e|l|o|w| |c|t|e|r|m|f| @9|1@2|,|1| @8|5@1|%| "
Run 2:
function
RunTheTest[40]..Test_relativenumber_colors[19]..VerifyScreenDump line 55: See
dump file difference: call
term_dumpdiff("testdir/failed/Test_relnr_colors_2.dump",
"testdir/dumps/Test_relnr_colors_2.dump"); difference in line 10: "|:|h|i|
|L|i|n|e|N|r|A|b|o|v|e| |c|t|e|r|m|f| @9|1@2|,|1| @8|5@1|%| "
function
RunTheTest[40]..Test_relativenumber_colors[23]..VerifyScreenDump line 55: See
dump file difference: call
term_dumpdiff("testdir/failed/Test_relnr_colors_3.dump",
"testdir/dumps/Test_relnr_colors_3.dump"); difference in line 10: "|:|h|i|
|L|i|n|e|N|r|B|e|l|o|w| |c|t|e|r|m|f| @9|1@2|,|1| @8|5@1|%| "
Flaky test failed too often, giving up
The problem above is that the display of the ":hi" command is getting truncated.
From test_popup.vim:
Found errors in Test_popup_and_previewwindow_dump():
Run 1:
function
RunTheTest[40]..Test_popup_and_previewwindow_dump[16]..VerifyScreenDump line
55: See dump file difference: call
term_dumpdiff("testdir/failed/Test_popup_and_previewwindow_01.dump",
"testdir/dumps/Test_popup_and_previewwindow_01.dump"); difference in line 19:
"|[+3#0000000&|N|o| |N|a|m|e|]| |[|+|]| @43|1@1|,|1| @10|B|o|t"
Run 2:
function
RunTheTest[40]..Test_popup_and_previewwindow_dump[16]..VerifyScreenDump line
55: See dump file difference: call
term_dumpdiff("testdir/failed/Test_popup_and_previewwindow_01.dump",
"testdir/dumps/Test_popup_and_previewwindow_01.dump"); difference in line 19:
"|[+3#0000000&|N|o| |N|a|m|e|]| |[|+|]| @43|1@1|,|1| @10|B|o|t"
Flaky test failed too often, giving up
For these, the line number is 10 when the dump file is expecting 11.
Not sure why these two tests are failing or what the right way to fix
them is.
Cheers,
--
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/20200223025901.5xmq4ag3lglctgod%40localhost.
