Am 18.05.2020 um 15:18 schrieb Bram Moolenaar:
Am 15.05.2020 um 22:31 schrieb Bram Moolenaar:
Patch 8.2.0762
Problem: Buffer is not considered modified after setting crypt key.
Solution: Set the modified flag. (Christian Brabandt, closes #6082)
Files: src/optionstr.c, src/testdir/test_crypt.vim
*** ../vim-8.2.0761/src/optionstr.c 2020-04-17 19:41:16.100078313 +0200
--- src/optionstr.c 2020-05-15 22:28:34.399878939 +0200
***************
*** 1157,1164 ****
--- 1157,1167 ----
if (STRCMP(curbuf->b_p_key, oldval) != 0)
// Need to update the swapfile.
+ {
ml_set_crypt_key(curbuf, oldval,
*curbuf->b_p_cm == NUL ? p_cm : curbuf->b_p_cm);
+ changed_internal();
+ }
}
Does it really do a before-after comparison of the key?
If so ... maybe ... will this make it easier to guess a key?
Ie, just guess a key and then check 'modified'?
That only means the key is the same as before, not whether it's right or
wrong. If someone would walk away from the keyboard then you can read
the text already, no need to guess the key, just do
":w !cat >/usr/me/public/secret.txt".
Or look at the sticky notes on the display for the password.
Yeah, encryption safety is not always related to the algorithm :-).
It just didn't seem right, but looks like the only thing to worry
about here are the sticky notes ^^
--
Andy
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/5EC2C316.6060906%40yahoo.de.
