Christian wrote:
> On Sa, 02 Jan 2021, Bram Moolenaar wrote: > > > Patch 8.2.2275 > > Problem: CTRL-C not recognized in Mintty. > > Solution: Recognize the modifyOtherKeys code ending in "u". (Christian > > Brabandt, closes #7575) > > Files: src/ui.c > > Thanks for including this. However I noticed one thing in the current > code: > > https://github.com/vim/vim/blob/02faa944c69ea22a7a5338135b686dac2c946ca1/src/ui.c#L1015-L1024 > > #v+ > 1015 /* > 1016 * If a CTRL-C was typed, remove it from the buffer and set > 1017 * got_int. Also recognize CTRL-C with modifyOtherKeys set, in > two > 1018 * forms. > 1019 */ > 1020 if (ctrl_c_interrupts && (inbuf[inbufcount] == 3 > 1021 || (len >= 9 && STRNCMP(inbuf + inbufcount, > 1022 "\033[27;5;99~", 10) == 0) > 1023 || (len >= 7 && STRNCMP(inbuf + inbufcount, > 1024 "\033[99;5u", 7) == 0))) > #v- > > I think the `len >= 9` on line 1021 should be `len >= 10`, because this > is what we use in the STRNCMP Yeah, it still works, but it's more logical to use the same number in both places. -- Where do you want to crash today? /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/202101021914.102JEt3f1930353%40masaka.moolenaar.net.
