On 4/21/22 1:35 PM, Hisashi T Fujinaka wrote:
OK, so THIS is the commit that I'm having trouble with (makes more
sense).

On my system I get

   $ srcgrep /usr/include gdk_window_get_height
   /usr/include/gtk-3.0/gdk/gdkwindow.h:int gdk_window_get_height     
   (GdkWindow       *window);

To propose a fix I need to know a bit about other implementations of gtk, '1' and '2' I guess. Are these methods, or something similar available? I could create a patch that only works with gtk3.

Hmm, in vim/src/Makefile there's the comment

   # Use this with GCC to check for mistakes, unused arguments, etc.
   # Note: If you use -Wextra and get warnings in GTK code about function
   #       parameters, you can add -Wno-cast-function-type (but not
   with clang)

I don't know if that has a bearing here, do these functions appear in gtk-2?

-ernie


% git bisect bad
9f53e7bd7f0865585a5447fa3665c5d4c4f91408 is the first bad commit
commit 9f53e7bd7f0865585a5447fa3665c5d4c4f91408
Author: Ernie Rael <[email protected]>
Date:   Sun Apr 17 18:27:49 2022 +0100

    patch 8.2.4776: GTK: 'lines' and 'columns' may change during startup

    Problem:    GTK: 'lines' and 'columns' may change during startup.
    Solution:   Ignore stale GTK resize events. (Ernie Rael, closes #10179)

 src/gui_gtk_x11.c | 168 ++++++++++++++++++++++++++++++++++++++++++++++++++++--
 src/version.c     |   2 +
 2 files changed, 164 insertions(+), 6 deletions(-)

I've diffed the output of config and make and no change on config. Make
only changes after the errors start:

gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK -I/opt/sw/include/gtk-2.0 -I/opt/sw/lib/gtk-2.0/include -I/opt/sw/include/gtk-2.0 -I/opt/sw/include/pango-1.0 -I/opt/sw/include/atk-1.0 -I/opt/sw/include/cairo -I/opt/sw/include/pango-1.0 -I/opt/sw/include/glib-2.0 -I/opt/sw/lib/glib-2.0/include -I/opt/sw/include/freetype2 -I/opt/sw/include -I/opt/X11/include -MD -I/opt/sw/include -DMACOS_X  -g -O2 -I/opt/sw/include -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1     -I/usr/X11/include    -o objects/gui_gtk_x11.o gui_gtk_x11.c gui_gtk_x11.c:4139:14: error: implicit declaration of function 'gdk_window_get_width' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    int         w = gdk_window_get_width(win);
                    ^
gui_gtk_x11.c:4140:14: error: implicit declaration of function 'gdk_window_get_height' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    int         h = gdk_window_get_height(win);
                    ^
gui_gtk_x11.c:4140:14: note: did you mean 'gdk_window_get_origin'?
/opt/sw/include/gtk-2.0/gdk/gdkwindow.h:541:12: note: 'gdk_window_get_origin' declared here
gint          gdk_window_get_origin      (GdkWindow       *window,
              ^
2 errors generated.
make: *** [objects/gui_gtk_x11.o] Error 1
#


--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/aeec2144-5a3c-5b51-4c7e-863789266daf%40raelity.com.

Raspunde prin e-mail lui