On 01-May-2022 06:50, Tony Mechelynck wrote:
On Sat, Apr 30, 2022 at 5:12 PM Bram Moolenaar <b...@moolenaar.net> wrote:
Patch 8.2.4850
Problem: Mksession mixes up "tabpages" and "curdir" arguments.
Solution: Correct logic for storing tabpage in session. (closes #10312)
Files: src/session.c, src/testdir/test_mksession.vim
At this patchlevel, I get one warning in Huge, two each (but related)
in Big and Normal, none in Small and Tiny. The following comes from my
Normal build:
gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK
-I/usr/include/gtk-3.0 -I/usr/include/pango-1.0
-I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
-I/usr/include/harfbuzz -I/usr/include/freetype2
-I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi
-I/usr/include/uuid -I/usr/include/cairo -I/usr/include/pixman-1
-I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/gio-unix-2.0 -I/usr/include/wayland
-I/usr/include/libxkbcommon -I/usr/include/atk-1.0
-I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0
-I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -pthread
-O2 -fno-strength-reduce -Wall -Wno-deprecated-declarations
-D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -o
objects/session.o session.c
session.c: In function ‘ex_mkrc’:
session.c:982:21: warning: ‘tab_firstwin’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
982 | if (tab_firstwin->w_next != NULL)
| ~~~~~~~~~~~~^~~~~~~~
session.c:627:18: note: ‘tab_firstwin’ was declared here
627 | win_T *tab_firstwin;
| ^~~~~~~~~~~~
The message from my Huge build is (only slightly) different:
gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK
-I/usr/include/gtk-3.0 -I/usr/include/pango-1.0
-I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
-I/usr/include/harfbuzz -I/usr/include/freetype2
-I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi
-I/usr/include/uuid -I/usr/include/cairo -I/usr/include/pixman-1
-I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/gio-unix-2.0 -I/usr/include/wayland
-I/usr/include/libxkbcommon -I/usr/include/atk-1.0
-I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0
-I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -pthread
-O2 -fno-strength-reduce -Wall -Wno-deprecated-declarations
-D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -o
objects/session.o session.c
session.c: In function ‘makeopens’:
session.c:982:21: warning: ‘tab_firstwin’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
982 | if (tab_firstwin->w_next != NULL)
| ~~~~~~~~~~~~^~~~~~~~
Best regards,
Tony.
Hi Tony,
Try this patch.
Cheers
John
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/6e13fa5d-a469-a55e-5b05-0b3e907c4eed%40internode.on.net.
--- session.c.orig 2022-05-01 06:45:20.891175000 +1000
+++ session.c 2022-05-01 07:51:19.647761100 +1000
@@ -624,7 +624,7 @@
char_u *sname;
win_T *edited_win = NULL;
int restore_stal = FALSE;
- win_T *tab_firstwin;
+ win_T *tab_firstwin = NULL;
frame_T *tab_topframe;
int cur_arg_idx = 0;
int next_arg_idx = 0;
