Hi All,
mingw64 (gcc 11.3.0) link fails if FEAT_PROP_POPUP is defined but
FEAT_QUICKFIX and FEAT_SPELL are not with this error message:
<snip>
gcc -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603
-DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO
-pipe -march=native -Wall -O3 -fomit-frame-pointer -freg-struct-return
-fpie -fPIE -Wl,-nxcompat,-dynamicbase -municode -s -o vim.exe
objnative/alloc.o objnative/arabic.o objnative/arglist.o
objnative/autocmd.o objnative/beval.o objnative/blob.o
objnative/blowfish.o objnative/buffer.o objnative/bufwrite.o
objnative/change.o objnative/charset.o objnative/cindent.o
objnative/clientserver.o objnative/clipboard.o objnative/cmdexpand.o
objnative/cmdhist.o objnative/crypt.o objnative/crypt_zip.o
objnative/debugger.o objnative/dict.o objnative/diff.o
objnative/digraph.o objnative/drawline.o objnative/drawscreen.o
objnative/edit.o objnative/eval.o objnative/evalbuffer.o
objnative/evalfunc.o objnative/evalvars.o objnative/evalwindow.o
objnative/ex_cmds.o objnative/ex_cmds2.o objnative/ex_docmd.o
objnative/ex_eval.o objnative/ex_getln.o objnative/fileio.o
objnative/filepath.o objnative/findfile.o objnative/float.o
objnative/fold.o objnative/getchar.o objnative/gui_xim.o
objnative/hardcopy.o objnative/hashtab.o objnative/help.o
objnative/highlight.o objnative/if_cscope.o objnative/indent.o
objnative/insexpand.o objnative/json.o objnative/list.o
objnative/locale.o objnative/main.o objnative/map.o objnative/mark.o
objnative/match.o objnative/memfile.o objnative/memline.o
objnative/menu.o objnative/message.o objnative/misc1.o objnative/misc2.o
objnative/mouse.o objnative/move.o objnative/mbyte.o objnative/normal.o
objnative/ops.o objnative/option.o objnative/optionstr.o
objnative/os_mswin.o objnative/os_win32.o objnative/pathdef.o
objnative/popupmenu.o objnative/popupwin.o objnative/profiler.o
objnative/quickfix.o objnative/regexp.o objnative/register.o
objnative/scriptfile.o objnative/screen.o objnative/search.o
objnative/session.o objnative/sha256.o objnative/sign.o
objnative/spell.o objnative/spellfile.o objnative/spellsuggest.o
objnative/strings.o objnative/syntax.o objnative/tag.o objnative/term.o
objnative/testing.o objnative/textformat.o objnative/textobject.o
objnative/textprop.o objnative/time.o objnative/typval.o objnative/ui.o
objnative/undo.o objnative/usercmd.o objnative/userfunc.o
objnative/version.o objnative/vim9cmds.o objnative/vim9compile.o
objnative/vim9execute.o objnative/vim9expr.o objnative/vim9instr.o
objnative/vim9script.o objnative/vim9type.o objnative/viminfo.o
objnative/winclip.o objnative/window.o objnative/os_w32exe.o
objnative/vimres.o objnative/xdiffi.o objnative/xemit.o
objnative/xprepare.o objnative/xutils.o objnative/xhistogram.o
objnative/xpatience.o objnative/iscygpty.o -lkernel32 -luser32 -lgdi32
-ladvapi32 -lcomdlg32 -lcomctl32 -lnetapi32 -lversion -lole32 -luuid
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
objnative/popupwin.o:popupwin.c:(.text+0xd96): undefined reference to
`ml_append_buf'
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
objnative/popupwin.o:popupwin.c:(.text+0xdf5): undefined reference to
`ml_append_buf'
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
objnative/popupwin.o:popupwin.c:(.text+0xe4a): undefined reference to
`ml_append_buf'
collect2.exe: error: ld returned 1 exit status
make: *** [Make_cyg_ming.mak:1107: vim.exe] Error 1
make: Target 'all' not remade because of errors.
The attached patch seems to fix it.
Cheers
John
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/b6cd9081-20cc-34c2-8709-45229727c5dd%40internode.on.net.
--- memline.c.orig 2022-04-16 05:45:42.822622300 +1000
+++ memline.c 2022-05-16 06:48:24.486973300 +1000
@@ -3361,7 +3361,7 @@
}
-#if defined(FEAT_SPELL) || defined(FEAT_QUICKFIX) || defined(PROTO)
+#if defined(FEAT_SPELL) || defined(FEAT_QUICKFIX) || defined(FEAT_PROP_POPUP)
|| defined(PROTO)
/*
* Like ml_append() but for an arbitrary buffer. The buffer must already have
* a memline.
