John Marriott wrote:
> On 14-June-2022 06:43, Bram Moolenaar wrote: > > Patch 8.2.5084 > > Problem: When the GUI shows a dialog tests get stuck. > > Solution: Add the --gui-dialog-file argument. > > Files: runtime/doc/starting.txt, src/Make_mvc.mak, src/gui.c, > > src/main.c, > > src/message.c, src/os_mswin.c, src/proto/gui.pro, > > src/proto/main.pro, src/structs.h, src/testdir/Make_dos.mak, > > src/testdir/Make_ming.mak, src/testdir/Makefile, > > src/testdir/runtest.vim, src/testdir/shared.vim > > > > > After this patch mingw64 (gcc 12.1) spits out this warning: > <snip> > gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 > -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO > -pipe -march=native -Wall -O3 -fomit-frame-pointer -freg-struct-return > -fpie -fPIE -DFEAT_GUI_MSWIN -DFEAT_CLIPBOARD os_mswin.c -o > gobjnative/os_mswin.oos_mswin.c: In function 'display_errors': > > os_mswin.c:681:61: warning: pointer targets in passing argument 2 of > 'gui_dialog_log' differ in signedness [-Wpointer-sign] > 681 | if (!gui_dialog_log((char_u *)"Errors", p)) > | ^ > | | > | char * > In file included from proto.h:278, > from vim.h:2255, > from os_mswin.c:16: > proto/gui.pro:70:43: note: expected 'char_u *' {aka 'unsigned char *'} > but argument is of type 'char *' > 70 | int gui_dialog_log(char_u *title, char_u *message); > | ~~~~~~~~^~~~~~~ > </snip> > > The attached patch tries to fix it. Thanks. Can also drop the typecast just below. -- Sometimes I think the surest sign that intelligent life exists elsewhere in the universe is that none of it has tried to contact us. (Calvin) /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20220613213329.3B51F1C06E5%40moolenaar.net.