On Tue, Jul 26, 2022 at 3:27 PM Bram Moolenaar <[email protected]> wrote: > > > Felipe Contreras wrote: > > > In issue #3205 a monkey patch was mentioned, but it wasn't the proper > > fix, the proper fix is in GetJavascriptIndent(), which was done in > > 2018 [1]. > > > > However, the proper fix was not included, in fact, the javascript files > > have not been updated since 2017. > > > > The monkey patch screwed all indentation inside blocks, like: > > > > <script> > > function test() { > > let v1; > > } > > test(); > > </script> > > > > We need to remove the monkey patch, and include the correct fix. > > I tried including this, but "make test" in runtime/indent fails.
I see, I missed subsequent changes, I've grouped them together and now the tests pass. > I would think the right solution is: > > <script> > var v1 = "v1"; > var v2 = "v2"; > </script> That is the correct behavior only when g:html_indent_script1 is not "zero", which in that particular test it is. > Have you tried contacting Chris Paul? His activity on github has > stopped a few years ago. He is in Cc. -- Felipe Contreras -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAMP44s3fAQ1W1j%3DLXzypfnujaMZKK4s0ZHq-Un8rBvT2P5DsHQ%40mail.gmail.com.
