> > You might want to store the hash number with the function to avoid the > > overhead of computing it. > > This still needs to be done. To make sure I understand, > this is saving `hash_hash(name)` in ufunc_T and has_profiling has an > additional argument which is the hash. And if this argument is zero > then the hash would be computed in has_profiling.
I haven't looked at the PR yet, but I would think that as soon as you have the function pointer, you can use the field that has the hash value. It is based on the function name, which doesn't change. Thus it needs to be computed only once. However, if you mean the hash value of the pattern, then it would be stored in "struct debuggy". Obviously it depends on what key you use for the hash table. > > The overhead of looking up the key in the > > table can't be avoided. Also, when more function names are being cached > > updating the hash table can also take a noticable amount of time. > > Yes, but it also would usually indicate that the table has been very > useful. > > I don't know most use cases; does the number of things being profiled > change dynamically or very often? That completely depends on what you are doing. Assuming you first start Vim and all plugins are loaded before you start profiling, then more plugins would be loaded when you access files with a certain filetype. Assuming you make changes (to scripts and/or source code) then Vim needs to restart before you measure another profile. Just make sure you use the same order of commands each time, otherwise results might not be showing the effect of your changes correctly. -- Overflow on /dev/null, please empty the bit bucket. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20230324174502.891CA1C0660%40moolenaar.net.
